Jump to content

[TOPIC: topicViewTemplate]
[GLOBAL: userSmallPhoto]
Photo

iPhone X AdMob Ad Rendering Question!
Started by d.mach Oct 27 2017 01:52 AM

76 replies to this topic
iphonex iphone iphone x admob banner
[TOPIC CONTROLS]
Page 2 of 4 1 2 3 4
This topic has been archived. This means that you cannot reply to this topic.
[/TOPIC CONTROLS]
[modOptionsDropdown]
[/modOptionsDropdown]
[reputationFilter]
[TOPIC: post.html]
#26

karpovpw

[GLOBAL: userInfoPane.html]
karpovpw
  • Contributor

  • 257 posts
  • Corona Staff

Ya, I didn't include it since I thought that this is redundant, but for me everything is fine in landscape too. Well, the position looks weird and that's one point to look for in the future update, but banners are at least displaying.

Attached File  Снимок экрана 2017-11-01 в 21.28.59.png   90.88KB   2 downloads

Attached File  Снимок экрана 2017-11-01 в 21.29.04.png   93.04KB   2 downloads

Don't worry, dislam, we'll figure it out together. And as I said, it's no problem to update our plugin before deadline, I just have to figure out what exactly is wrong now to insure that simple sdk update eliminates all the issues.



[TOPIC: post.html]
#27

chris_raz

[GLOBAL: userInfoPane.html]
chris_raz
  • Contributor

  • 221 posts
  • Corona SDK

Hi @karpovpw, i just wanted to clarify, so displaying the banner in the test screenshots you provided, you did not set any Y value for when showing banner? simply top or bottom and the result came out as you showed without having to get the insets and setting the Y of the banner?



[TOPIC: post.html]
#28

dislam

[GLOBAL: userInfoPane.html]
dislam
  • Contributor

  • 179 posts
  • Corona SDK

Hi @karpovpw, i just wanted to clarify, so displaying the banner in the test screenshots you provided, you did not set any Y value for when showing banner? simply top or bottom and the result came out as you showed without having to get the insets and setting the Y of the banner?

 

 

I'm guessing it's:  y = screenHeight - safeYFromBottom

 

If you use y = "bottom" it will stick to the bottom of the screen and be obscured by the gesture bar.

 

 

BTW @karpovpw can you share how you set up the ad?  i.e. the init, adListener and display routines?



[TOPIC: post.html]
#29

karpovpw

[GLOBAL: userInfoPane.html]
karpovpw
  • Contributor

  • 257 posts
  • Corona Staff

Hi dislam and chris_raz,

This is just a sample from our admob plugin. You can download it and check everything for yourself. I guess, I can just pin it here for everyone's convenience. You can even play with it a little.

In the mean time, can you explain to me, what problem do we need to solve exactly, besides:

1. Obvious sdk update;
2. Fix landscape iPhone X banner location.

Well, to think twice, I guess, I can implement safe area layout update for portrait mode too, since, well, you CAN modify y value of banner position in show() method, but with the safe area it would have more consistent look on all devices, including iX.

Oh, and I guess that admob sdk update isn't ready yet, since on their doc page that you've mentioned, it says: "We will update the release notes and this documentation page when this change is available. Last updated October 18, 2017."

Attached Files



[TOPIC: post.html]
#30

dislam

[GLOBAL: userInfoPane.html]
dislam
  • Contributor

  • 179 posts
  • Corona SDK

Hi @karpovpw, thanks for sharing.  At the moment, I need to confirm two things

 

1. Whether this is a common problem among other developers running Xcode sim for the iPhone X (still waiting for someone else).

2. Whether my ads work if I modify my adMob code to match your implementation.  I'll try to work on this tonight and respond afterward.



[TOPIC: post.html]
#31

dislam

[GLOBAL: userInfoPane.html]
dislam
  • Contributor

  • 179 posts
  • Corona SDK

Hi dislam and chris_raz,

This is just a sample from our admob plugin. You can download it and check everything for yourself. I guess, I can just pin it here for everyone's convenience. You can even play with it a little.

In the mean time, can you explain to me, what problem do we need to solve exactly, besides:

1. Obvious sdk update;
2. Fix landscape iPhone X banner location.

Well, to think twice, I guess, I can implement safe area layout update for portrait mode too, since, well, you CAN modify y value of banner position in show() method, but with the safe area it would have more consistent look on all devices, including iX.

Oh, and I guess that admob sdk update isn't ready yet, since on their doc page that you've mentioned, it says: "We will update the release notes and this documentation page when this change is available. Last updated October 18, 2017."

 

 

OK, I just tried the example app you attached.  I had to include my own Images.xcassets folder for it to build successfully and to launch in the Xcode simulator for iPhone X.

 

Now, when hit the "Load" button for the Interstitial or Rewarded ads, the green light comes on and I can "Show" the ads.

 

However the same is NOT true for Banner ads.  The green light never comes on!  Strange that it works for you.

 

 

EDIT:  Never mind, solved it!   I thought I had been using XCode 9.1, but in fact I had 9.0.1.  I updated it, and now I can see the banners!  Haha!   

 

 

Sorry to waste any of your time but I appreciate the help!



[TOPIC: post.html]
#32

karpovpw

[GLOBAL: userInfoPane.html]
karpovpw
  • Contributor

  • 257 posts
  • Corona Staff

Sorry to waste any of your time but I appreciate the help!

We're here to help you. Ask whatever question you need and share your rough goings - we'll be glad to help you. Great news that everything is working fine for you now.

 

2. Whether my ads work if I modify my adMob code to match your implementation.  I'll try to work on this tonight and respond afterward.

 

One of the main points of future update will be to maintain existing user's code. You do not need to change anything with new update, things will just be working on the iPhone X.

And yea, the latest sdk update on Google's side was 2017‑10‑25, but still no iPhone X specific interstitial/r.video layouts.  -_- 



[TOPIC: post.html]
#33

hogletpie

[GLOBAL: userInfoPane.html]
hogletpie
  • Contributor

  • 148 posts
  • Corona SDK

 

 

One of the main points of future update will be to maintain existing user's code. You do not need to change anything with new update, things will just be working on the iPhone X.

What does this mean for apps updated with Xcode 8.3.3 and Corona 3126? I have no interest in updating my apps.

 

Will banner and interstitial ads be served on the iPhone X? If the banner ads are served on the iPhone X, are they served in the safe region?



[TOPIC: post.html]
#34

karpovpw

[GLOBAL: userInfoPane.html]
karpovpw
  • Contributor

  • 257 posts
  • Corona Staff

I can answer this questions only when admob release their new update for iX, since that is fully on admob's side of things, how they're going to implement it. We may be doing something like this: leave old admob plugin available on old corona sim versions (like, older than 3167, since it already requires xcode 9 to work properly) and new admob plugin with updated sdk will be available on new versions.

But admob position right now is unclear: you must use safe area for iX (that feature is available only on xcode 9 and later) before 20 Nov. But what if you don't update it and just stay on an older sdk version? Not sure about that as of right now.

We'll figure it out.

Oh, actually I can answer one of your question: 

 

If the banner ads are served on the iPhone X, are they served in the safe region?

Definitely no. I'm sorry to say that, but, as I already noticed, that feature is only for xcode >=9 platform sdk.



[TOPIC: post.html]
#35

hogletpie

[GLOBAL: userInfoPane.html]
hogletpie
  • Contributor

  • 148 posts
  • Corona SDK

Thanks for the prompt reply.

 

bellissimo posts here about banners:

http://iphonedevsdk.com/forum/business-legal-app-store/123689-why-dont-apple-devs-get-iphonex-delivery-priority.html

 

Mention of compatibility mode?

 

My Corona apps were compiled using iOS 10 / Xcode 8.3.3 and Corona 3126

 

I suppose the KEY question is for those (including myself) who do not wish to update is: What will happen to existing apps that attempt to serve a banner ad on iPhone X? From your reply above, the banners will not be served in the safe region. But, will the banners be served at all on iPhone X?

 

If the answer is no (and I hope the answer is no, as the banners will not be served in the safe region) then perhaps AdMob will allows apps to continue serving ads after November 20th?

 

I hope AdMob will not be draconian and discontinue all ad serving en masse of those developers who do not update. 



[TOPIC: post.html]
#36

karpovpw

[GLOBAL: userInfoPane.html]
karpovpw
  • Contributor

  • 257 posts
  • Corona Staff

Well, you now, actually, I totally forgot that your apps are already built with iOS 10 platform sdk and thus will be shown on iX in, as you say, compatibility mode (mostly like that was on an i4S -> i5 era). Admob can be picky and change banners (maybe inter/r.video) logic on their older sdk (like, stop showing ads altogether or something), but my personal thought is that banners will be shown in this compatibility mode too, like, the whole app with the banners inside will be just 16:9 and if it works well for i8, it will be looking exactly like tht on iX (except fro obvious borders on top and bottom).

Apple itself are pretty picky about this stuff too, but for now it's just not recommended to use this compatibility mode. Sometime in future this design may become forbidden and apps will be forbidden to update/released new. We'll see.



[TOPIC: post.html]
#37

dislam

[GLOBAL: userInfoPane.html]
dislam
  • Contributor

  • 179 posts
  • Corona SDK

I just want to mention that when the device is in landscape mode on the iPhone X (with the notch on the left side), I notice that those banners ads are shifted a bit to the right. They are not lined up against the left edge of the bezel. So any Install buttons that are on the right side of the banner are only shown partially.

I don’t have a screenshot at the moment but I hope you know what I mean.

[TOPIC: post.html]
#38

sararose

[GLOBAL: userInfoPane.html]
sararose
  • Observer

  • 12 posts
  • Corona SDK

Thanks for the prompt reply.

 

bellissimo posts here about banners:

http://iphonedevsdk.com/forum/business-legal-app-store/123689-why-dont-apple-devs-get-iphonex-delivery-priority.html

 

Mention of compatibility mode?

 

My Corona apps were compiled using iOS 10 / Xcode 8.3.3 and Corona 3126

 

I suppose the KEY question is for those (including myself) who do not wish to update is: What will happen to existing apps that attempt to serve a banner ad on iPhone X? From your reply above, the banners will not be served in the safe region. But, will the banners be served at all on iPhone X?

 

If the answer is no (and I hope the answer is no, as the banners will not be served in the safe region) then perhaps AdMob will allows apps to continue serving ads after November 20th?

 

I hope AdMob will not be draconian and discontinue all ad serving en masse of those developers who do not update. 

 

Hogletpie,

I'm in the same position as you are. At the moment, I do not want to update any of my iOS apps because one of them were flagged for 4.3 design spam. I emailed my admob representative to ask if on the back-end admob can turn off ads served to iPhone X devices for my account, because I cannot update my iOS apps for the time being. It's been a week since my email and I haven't gotten a reply, even though they usually reply to me the same day or next day. I'll keep you posted if I hear back from them.



[TOPIC: post.html]
#39

karpovpw

[GLOBAL: userInfoPane.html]
karpovpw
  • Contributor

  • 257 posts
  • Corona Staff

I just want to mention that when the device is in landscape mode on the iPhone X (with the notch on the left side), I notice that those banners ads are shifted a bit to the right. They are not lined up against the left edge of the bezel. So any Install buttons that are on the right side of the banner are only shown partially.

I don’t have a screenshot at the moment but I hope you know what I mean.

Of course, because new plugin update hasn't been released yet.  ;) All layout inconsistencies will be fixed on all devices.



[TOPIC: post.html]
#40

hogletpie

[GLOBAL: userInfoPane.html]
hogletpie
  • Contributor

  • 148 posts
  • Corona SDK

@karpovpw - thanks for the reply. I will watch with interest what happens on the 21st November - the day after their "deadline" date. I suspect even AdMob aren't sure how they will respond as yet after the 20th...?

 

@sararose - that's most interesting. I feel that many will not update due to Apple reviewers' arbitrary interpretation of the guidelines. I'd be interested to know what reason you gave AdMob for not updating (if you gave them a reason at all).

 

It really does make sense for AdMob to continue to serve ads to all devices and simply switch off those ad requests from iPhone X (for those developers who have not updated). Alternatively serve the ads for iPhone X (assuming that the app displays with black bars). The nightmare scenario is AdMob simply flicking a switch and stopping all ads being served for all developers who have not updated.

 

I have the option to remotely switch ad providers without updating. I really do not want to do that. Not only will I lose banners across all my apps but no network (in my experience) comes close to AdMob. 

 

It pains me to be even having this discussion about not updating. Apple are a dictatorship and completely unpredictable with their review guideline interpretation. Many developers have posted in several forums about the "spam rejection" and "put all related apps into a container app" rejections. It's caused great anxiety and consternation for many! Rant over! ;-)



[TOPIC: post.html]
#41

sararose

[GLOBAL: userInfoPane.html]
sararose
  • Observer

  • 12 posts
  • Corona SDK

@hogletpie - No, I didn't give my admob representative a reason. Fingers crossed everything will work out fine for all of us!



[TOPIC: post.html]
#42

chris_raz

[GLOBAL: userInfoPane.html]
chris_raz
  • Contributor

  • 221 posts
  • Corona SDK

The worst part of it all is, they have given a deadline of November 20, but admob themselves have not updated their sdk. I'm in a crunch now deciding what to do,start updating all my apps, which won't just be admob but also older libraries to new for them to work, then update them all again once the new plugin or admob sdk comes out as they say they have changes for interstitials for iPhone X, (nightmare) or wait til they release the new sdk hopefully before the 20th and have less time to update and test all the apps. Either way it's a nightmare! Going on holidays on the 16th so makes matters worse for me.

[TOPIC: post.html]
#43

hogletpie

[GLOBAL: userInfoPane.html]
hogletpie
  • Contributor

  • 148 posts
  • Corona SDK

My feeling is they will extend the deadline and/or not simply "throw a switch" and stop serving ads across all devices.

 

AdMob don't say what they will do after the 20th. Probably because they have yet to decide. Their decision may be based on how many developers update...

 

Time will tell...



[TOPIC: post.html]
#44

chris_raz

[GLOBAL: userInfoPane.html]
chris_raz
  • Contributor

  • 221 posts
  • Corona SDK

Ideally yes, but I would not ignore a policy for which they clearly are outlining and having a notification for at the top of the admob dashboard. I think it's better to be safe than sorry. i don't think they need to say what they will do after the 20th as their policies already mention that. they have already mentioned it will not be compliant if they find the ads are not shown correctly on iPhone x

[TOPIC: post.html]
#45

hogletpie

[GLOBAL: userInfoPane.html]
hogletpie
  • Contributor

  • 148 posts
  • Corona SDK

I wonder what non-compliance results in? Simply stopping the ads served on the iPhone X or, more severely, stopping all ad serving across all devices?



[TOPIC: post.html]
#46

chris_raz

[GLOBAL: userInfoPane.html]
chris_raz
  • Contributor

  • 221 posts
  • Corona SDK

Hi @karpovpw finally getting around to doing some testing with the iphone x simulator, thanks for your help so far! the first app im updating is a landscape app. and interstitials are showing within the safe area already without any changes, so possibly admob has already got something in place without updating the sdk?

 

With the banner in landscape, im wondering if that push to the right is also something admob is automatically doing? as from what i can see, the banner starts from exactly where the left/top rounded corner on the iphone ends, but the end goes past the screens display on the right(which is not good as thats the side they usually have the button to click the ad) . i think the correct showing would be it starts at the end of the left/top corner as it does already, but ends at the start of the right/top corner. again this is all in landscape mode.

Is there any update on this? as i cant submit an app with the banner (and most commonly in admob the banner ads call to action area) going off the right of the screen



[TOPIC: post.html]
#47

hogletpie

[GLOBAL: userInfoPane.html]
hogletpie
  • Contributor

  • 148 posts
  • Corona SDK

Hopefully someone can chime in with banner (and interstitial) behaviour in portrait mode! :-)



[TOPIC: post.html]
#48

karpovpw

[GLOBAL: userInfoPane.html]
karpovpw
  • Contributor

  • 257 posts
  • Corona Staff

Is there any update on this?

Hi, chris_raz,

About the interstitials: no, right now they are not showing inside the safe area. You might be confusing simple "everything is on the screen visible" with "safe area". These changes will come from admob, you'll see what I meant in their new sdk update.

 

Admob demands are pretty obvious - banners should be inside safe area and it must be done on the apps side (e.g. on corona side for us). This fixes will be available to you on the next admob plugin update, which will become public when admob finally releases their sdk update.

What's strange is their sdk update itself, or rather it's absence. The guide page was updated on November 4th (some smart banners code snippets), but still no info about this new update. Like, whatta heck, Google? I was afraid that I was doing something wrong, but new release is obviously not on the https://developers.google.com/admob/ios/rel-notes still.



[TOPIC: post.html]
#49

chris_raz

[GLOBAL: userInfoPane.html]
chris_raz
  • Contributor

  • 221 posts
  • Corona SDK

Hi again @karpovpw, thanks for your quick reply,

im not so sure, i dont see that they mention they will be updating their sdk for banners, i only see them mentioning it being updated for the rewarded ads and interstitials. see here at the bottom of this page. https://developers.google.com/admob/ios/x-ad-rendering

for banners it seems as though we should be fixing this now regardless of the new sdk. there is alot of warnings coming from them, the email, the top  of admobs dashboard, etc...

 

In terms of the interstitial im getting im wondering with the amount of time its taking them to update the sdk, they already have a fix in the current one... take a look at the screenshot, i have made no changes, but it is showing in the safe zone.

Attached File  Screen Shot 2017-11-06 at 10.03.24 pm.png   1.14MB   1 downloads

 

and the banner, i have also made no changes, i understand in portrait we would need to modify the y position for both top and bottom, but currently in landscape, it seems like the banner is starting in the right spot, and this only happens on iphone x which makes me beleive this is a admob feature as opposed to bug, the only problem is, i think the banner should only have the length of the actual safe area as opposed to the actual area hence its stretching beyond the screen. see attached below.

Attached File  Screen Shot 2017-11-06 at 10.01.11 pm.png   230.55KB   1 downloads

 



[TOPIC: post.html]
#50

karpovpw

[GLOBAL: userInfoPane.html]
karpovpw
  • Contributor

  • 257 posts
  • Corona Staff

i dont see that they mention they will be updating their sdk for banners, i only see them mentioning it being updated for the rewarded ads and interstitials

Yea, what I meant is: we will update our plugin as soon as admob will update their sdk, since I think we shouldn't force our users to update their apps two times because of two new plugin releases instead of just one.

Since interstitials is not inside safe areas in the portrait mode, I'm guessing that this is just a coincidence, that everything looks ok in the landscape. Can't say anything else about it.




[topic_controls]
Page 2 of 4 1 2 3 4
 
[/topic_controls]